Recent Battles (in Changelog)
June 2 2008 8:14 AM EDT
Looking kind of nice there Jon....
June 2 2008 8:17 AM EDT
I like the way you're incorporating Veri's script. It's nice to be able to do the same things away from my own computer as I can at home.
More of Verifex's work.
Although it looks like i get to fix the links. :)
The dark red on dark red for visited links is very hard to see:
i see the plus for adding opponents, will we get a minus symbol for removing them as well?
June 2 2008 10:39 AM EDT
Personally I don't mind there being no minus function on that page. It would be too easy to accidently remove people. I don't mind accidently adding people, that's easy to fix. But deleting one is a little harder to put right.
June 2 2008 10:50 AM EDT
I liked on the old script being able to add and remove people from the recent battle list. I actually use the remove more than the add.
What would be really cool is if it would be a + to add and - to removed but having them change based on if the opponent was already in your fight list. So for instance if you had Hubbell in your fight list then when you looked at the recent battles it would show him as a - , and if you removed him from your fight list then when you looked at recent battles it would show him as a +.
Sorry I am long winded.
Looks good, but clan links don't seem to work anymore.
June 2 2008 10:50 AM EDT
Oh and sorry I meant to also say that it looks great, good job guys on the change.
June 2 2008 10:57 AM EDT
hey also just foud an issue.
if you look at anybody else's 24 hour battle summary, then it shows this at the top, obviously something is a little off with the coding.
<a href=/inspect_opponent.tcl?opponent_id=109>Anbhas</a> has participated in 1426122 battles, of which he won 871672, or 61%.
June 2 2008 11:00 AM EDT
in addition to my last post I noticed that the < and > are being translated into < and >
fixed clan & peter's links
NS: i imagine setting visited to same as non- for button class would fix that
June 2 2008 11:36 AM EDT
Whoa....didn't notice the thread until I looked at my recent battles and saw tons of pink!!
Cool change, Jon! :)
Jon: The Recent Battles list needs to be tweaked a little bit. All the opponents that I've battled show '+' next to their character's name to allow me to add to the favorite's list. For opponents that are already in the favorite's list, it should show '-' sign instead. Yes, it is understood it will take more processing time on the server side.
However, using the '+' feature handles the "error" gracefully, as it can see that an opponent has already been added in the list. Otherwise, we already have this feature in the Edit... feature.
It's not a perfect solution to the fight/add links on the recent battles page. I was envisioning a CSS section next to the minion that displayed the links, but I think Lamu would be better versed in that level of magic CSS. :) Any ideas Lamu?
Cool features, but a bit hard on the eyes IMO.
June 2 2008 9:23 PM EDT
The totals don't line up correctly for me. I have "totals" battles won, 432 battles lost, etc. Honestly, I'm not doing that poorly.
June 3 2008 6:17 AM EDT
My double taps don't come out right-The second battle appears before the first.
June 7 2008 7:52 PM EDT
Great improvement, thanks Jonathan and Verifex :)
I have the same issue small has....
This thread is closed to new posts.
However, you are welcome to reference it
from a new thread; link this with the html
<a href="/bboard/q-and-a-fetch-msg.tcl?msg_id=002Rsr">Recent Battles</a>