Boring CL 1 - forum quoting (in Changelog)


AdminNightStrike April 28 2010 11:52 AM EDT

Reworked the forum quoting. Please check to make sure it still works nicely. Hopefully, there are less instances where you get a quote that you didn't want because of a stray greater-than sign.

Admindudemus [jabberwocky] April 28 2010 11:54 AM EDT

Reworked the forum quoting. Please check to make sure it still works nicely. Hopefully, there are less instances where you get a quote that you didn't want because of a stray greater-than sign.

this change is
all others! ; )

AdminNightStrike April 28 2010 11:54 AM EDT

Darn :(

Admindudemus [jabberwocky] April 28 2010 11:54 AM EDT

i had typed this change is greater sign than all others above.

AdminNightStrike April 28 2010 11:56 AM EDT

Yeah, I figured as much.. I thought I tested that use case, too. This is why user testing is so important.

Admindudemus [jabberwocky] April 28 2010 11:58 AM EDT

go to your left plane and click on businesses>blacksmith>reforge an item with a name of power ~ to name your items.

the above is another way it has come up from my experience.

Admindudemus [jabberwocky] April 28 2010 11:59 AM EDT

^nice! ; )

AdminNightStrike April 28 2010 12:01 PM EDT

go to your left plane and click on businesses>blacksmith>reforge an item with a name of power ~ to name your items.

Um.. ?

Admindudemus [jabberwocky] April 28 2010 12:06 PM EDT

i use the greater sign as a form of shorthand for telling people the steps needed sometimes, i have had issues in the past doing that so was just testing this as well.

AdminShade April 28 2010 12:09 PM EDT

go to your left plane and click on businesses > blacksmith > reforge an item with a name of power ~ to name your items.

putting in spaces now seems to work? :)

AdminNightStrike April 28 2010 12:10 PM EDT

Oh, hahahah.. yeah, that's the kind of testing I'm looking for, thanks :)

And yes, I do that as well anytime I'm giving computer help (ie, do start>run>cmd>etc). So it seems it works as long as there's no space.

What's funny is that the regular expression says to match just the beginning of a line (^). Stupid regex.

AdminNightStrike April 28 2010 2:39 PM EDT

How is this not a valid regex?

regsub -line -all "(^|^<br>)?&gt; (.*)$" $clean_for_html {<div style='border:solid 1px maroon; padding:0.5em; background-color:#B0B0F0;'>\2</div>} clean_for_html


That, to me, says that if a line starts with '>' followed by a space, then do the quote thing. I have no idea how that can trigger in the middle of a line.

Salketer [big bucks] April 28 2010 2:43 PM EDT

The question mark makes the (^|^
) optionnal...

Salketer [big bucks] April 28 2010 2:45 PM EDT

>shouldn't quote
should be in quotes

A space after the >is required as you can see right here.

Salketer [big bucks] April 28 2010 2:48 PM EDT

"^(<br>)?&gt; (.*)$" is what I think could work. Also, some regular expression engines don't count ^ as new lines but beginning of a string, I don't know about this one.

AdminNightStrike April 28 2010 2:53 PM EDT

The question mark doesn't make it optional. It means "1 or more", similar to how the asterisk means "0 or more". It is required at least once.

Your version factors out the ^, which I agree is cleaner, but is otherwise syntactically equivalent. Maybe it'll be less confusing to the regex parser, too. I'll try it.

AdminNightStrike April 28 2010 2:54 PM EDT

Change will go active after cache flush.

Salketer [big bucks] April 28 2010 2:57 PM EDT

+ is for 1 or more, ? is 0 or 1 and * is 0 or more... The reason I took out the ^ of the parenthesis is to make sure it is required. If by putting a question mark you really meant to ask for 1 or more, the ^ has to be taken out too because you cannot have multiple ^ without having $ between them.

AdminNightStrike April 28 2010 3:00 PM EDT

You, sir, are correct.

That would definitely be the heart of my misconceptions.

Many, MANY thanks.

Salketer [big bucks] April 28 2010 3:01 PM EDT

Anytime NS :) But wait until cache flush, the problem may be something else.

AdminNightStrike April 28 2010 3:01 PM EDT

You know what.. I want to test this now. I'll be restarting the server. I just really want to see this work.

AdminNightStrike April 28 2010 3:02 PM EDT

so now this > should work right.

AdminNightStrike April 28 2010 3:02 PM EDT

Hah! Salk, you deserve some gratitude, for sure!

Salketer [big bucks] April 28 2010 3:03 PM EDT

:)

Admindudemus [jabberwocky] April 28 2010 3:04 PM EDT

woohoo! salk is > than ns at regex! ; )

thanks you two.

Admindudemus [jabberwocky] April 28 2010 3:16 PM EDT

i tried to break it all ways that i could think of. > it does seem to work fine now though. ; )

AdminQBGentlemanLoser [{END}] April 28 2010 3:24 PM EDT

>

Hehehehe. ;)

<3

AdminNightStrike April 28 2010 3:24 PM EDT

Good. Hopefully this one stays off the radar for a while. Thanks for testing it, too.

AdminQBGentlemanLoser [{END}] April 28 2010 3:27 PM EDT

One other thing to test, it always bugged me. ;)

Spacing test

It's all about the line breaks.

WOOT! Perfect! :D

AdminNightStrike April 28 2010 4:17 PM EDT

?

AdminQBGentlemanLoser [{END}] April 28 2010 4:21 PM EDT

before this change, the spacing was wonky.

You would type it like;

Line
(break)
Quote
(break)
Line

And it owuld actually post like

Line
Quote
(break)
Line

Now it's fine!

AdminNightStrike April 28 2010 4:26 PM EDT

Um.. you're welcome :)

Underage Drinking [Battle Royale] April 28 2010 6:16 PM EDT

yay

{EQ}Viperboy April 28 2010 11:50 PM EDT

thanks
This thread is closed to new posts. However, you are welcome to reference it from a new thread; link this with the html <a href="/bboard/q-and-a-fetch-msg.tcl?msg_id=0032m2">Boring CL 1 - forum quoting</a>