Boring CL 1 - forum quoting (in Changelog)

Reworked the forum quoting. Please check to make sure it still works nicely. Hopefully, there are less instances where you get a quote that you didn't want because of a stray greater-than sign.

this change is

Darn :(

i had typed this change is greater sign than all others above.

Yeah, I figured as much.. I thought I tested that use case, too. This is why user testing is so important.

go to your left plane and click on businesses>blacksmith>reforge an item with a name of power ~ to name your items.

the above is another way it has come up from my experience.

^nice! ; )

Um.. ?

i use the greater sign as a form of shorthand for telling people the steps needed sometimes, i have had issues in the past doing that so was just testing this as well.

putting in spaces now seems to work? :)

Oh, hahahah.. yeah, that's the kind of testing I'm looking for, thanks :)

And yes, I do that as well anytime I'm giving computer help (ie, do start>run>cmd>etc). So it seems it works as long as there's no space.

What's funny is that the regular expression says to match just the beginning of a line (^). Stupid regex.

How is this not a valid regex?

regsub -line -all "(^|^<br>)?&gt; (.*)$" $clean_for_html {<div style='border:solid 1px maroon; padding:0.5em; background-color:#B0B0F0;'>\2</div>} clean_for_html


That, to me, says that if a line starts with '>' followed by a space, then do the quote thing. I have no idea how that can trigger in the middle of a line.

The question mark makes the (^|^
) optionnal...

>shouldn't quote

A space after the >is required as you can see right here.

"^(<br>)?&gt; (.*)$" is what I think could work. Also, some regular expression engines don't count ^ as new lines but beginning of a string, I don't know about this one.

The question mark doesn't make it optional. It means "1 or more", similar to how the asterisk means "0 or more". It is required at least once.

Your version factors out the ^, which I agree is cleaner, but is otherwise syntactically equivalent. Maybe it'll be less confusing to the regex parser, too. I'll try it.

Change will go active after cache flush.

+ is for 1 or more, ? is 0 or 1 and * is 0 or more... The reason I took out the ^ of the parenthesis is to make sure it is required. If by putting a question mark you really meant to ask for 1 or more, the ^ has to be taken out too because you cannot have multiple ^ without having $ between them.

You, sir, are correct.

That would definitely be the heart of my misconceptions.

Many, MANY thanks.

Anytime NS :) But wait until cache flush, the problem may be something else.

You know what.. I want to test this now. I'll be restarting the server. I just really want to see this work.

so now this > should work right.

Hah! Salk, you deserve some gratitude, for sure!

:)

woohoo! salk is > than ns at regex! ; )

thanks you two.

i tried to break it all ways that i could think of. > it does seem to work fine now though. ; )

Hehehehe. ;)

<3

Good. Hopefully this one stays off the radar for a while. Thanks for testing it, too.

One other thing to test, it always bugged me. ;)


It's all about the line breaks.

WOOT! Perfect! :D

?

before this change, the spacing was wonky.

You would type it like;

Line
(break)
Quote
(break)
Line

And it owuld actually post like

Line
Quote
(break)
Line

Now it's fine!

Um.. you're welcome :)