The change you'll hopefully never see (in Changelog)

AdminNightStrike November 29 2010 3:25 PM EST

So I put in a big giant change to the fight page to try to do a lot of speed improvements. If I did it right, then there should be zero difference in the fights in terms of what causes the fight to go through or not. You should also see a slight speed improvement.

Basically, I took all the code that was doing all of the pre-fight validity checking (are you retired, are you a t-party, do you have enough money to heal, etc etc) and I cached that stuff. Then, I reordered the list so that the thing that triggers most often -- fighting a comatose opponent -- trips much earlier in the sequence list.

We'll see if that does anything.

AdminQBnovice [Cult of the Valaraukar] November 29 2010 3:48 PM EST

You're awesome!

AdminNemesia [Demonic Serenity] November 29 2010 3:49 PM EST

It does feel a good bit faster.

AdminTitan [The Sky Forge] November 29 2010 3:49 PM EST

Re-factoring sure is so much fun.

AdminShade November 29 2010 4:47 PM EST

Fighting did get faster for me, thanks! :)

Kefeck [Demonic Serenity] November 29 2010 4:50 PM EST

It's noticeably faster on my iPod..

Xenogard [Chaotic Serenity] November 29 2010 7:32 PM EST

Oh its definitely faster, usually there was a slight delay before all of the battle text would load up, now it shows up the second I click fight. Great work!

AdminQBnovice [Cult of the Valaraukar] November 30 2010 2:59 AM EST

Anyone else seeing an improvement in char switching?

Demigod November 30 2010 7:25 AM EST

I just cycled through about eight times without a failure, so YES.

QBOddBird November 30 2010 4:16 PM EST

Yeah, this definitely is faster. Super good invisi-change. :D

AdminShade November 30 2010 4:30 PM EST

Anyone else seeing an improvement in char switching?
Just tried switching and it took me 2 attempts to get the right one...

MissingNo December 1 2010 1:35 AM EST

Your ability to fight has been disabled for 10 minutes. Note that multiple suspensions will result in longer penalties, however you will continue to regenerate BA

To prevent this from occurring in the future, make sure that the fight page has finished loading before trying to fight again.


Demigod December 1 2010 1:41 AM EST

Just tried switching and it took me 2 attempts to get the right one...

It felt like a 50-50 chance of working before the change, and I haven't had a single problem switching since. Even if it's not perfect, it's vastly improved.

Pwned December 1 2010 1:43 AM EST

Wow awesome change.

Shadow Ruler December 8 2010 1:32 PM EST

Great change pat yourself on the back :D

AdminNightStrike January 5 2011 9:04 PM EST

I streamlined another section of the fight page. It has nothing to do with the current slowness... It's something that I did for the rituals that worked, but worked very inefficiently. It was on my "round-toit" list. Now is a good a time as any... The change will go live at cache flush.

For those that are curious, every fight hit the database several times. Now, those hits are memoized and flushed instead of pulling from the db each time.

I did it because a majority of the slowness seems to be database related (see the recent blackmarket fix), so pending database improvements got a higher priority.

Note that this won't fix the underlying cause of the fight slowness, but just a symptom of it. In fact, the fight slowness itself is an overall symptom of the *site* slowness, which is more and more seeming like a database issue.

AdminNightStrike January 5 2011 9:05 PM EST

I suppose since this thread is old and locked, it'd be nice for a kind admin to create a new thread, move my message there, and reference this old one..... Thanks for volunteering, dudemus :)
This thread is closed to new posts. However, you are welcome to reference it from a new thread; link this with the html <a href="/bboard/q-and-a-fetch-msg.tcl?msg_id=00384w">The change you'll hopefully never see</a>